Ask Your Question
0

Feedback please

asked 2020-04-28 10:02:12 -0500

Radek gravatar image

Hi, please can you check my work: https://codepen.io/rady2rady/pen/rNOwamO and first version also: https://codepen.io/rady2rady/pen/xxwqWpZ Thank you. Radek

edit retag flag offensive close merge delete

2 answers

Sort by » oldest newest most voted
0

answered 2020-04-29 14:36:27 -0500

aze gravatar image

Nice customization!

  • Try to use 2-3 fonts usually it just looks better from a design perspective
  • You don't have to put a CSS class on everything to select it in CSS, you can use tags to select them and you should only use classes when you want to differ from the rest of the elements
  • You can use more complex selectors for example instead of .inline the .title span is going to be the same, but you don't need the classes on them
  • Those by the way should be links, so you can use the a element instead of the span
  • Try not repeat things (like quote1:before, quote2:before, quote3:before) are exactly the same, you can use the blockquote tag and select them to create the rules for the before, since all quotes will look the same
  • The quotes are actually next to a specific part of the text and that's easy to achieve if you don't have 2 columns for the quotes and the text part, but you have rows for those and in the rows you have 2 columns for a quote and a text part.

But nice work so far :)

edit flag offensive delete link more
0

answered 2020-04-29 19:48:49 -0500

Radek gravatar image

Thank you Adam. I´m not so sure is nice work but thank´s for your tips. Need more practice :)

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

1 follower

Stats

Asked: 2020-04-28 10:02:12 -0500

Seen: 19 times

Last updated: Apr 29