Ask Your Question
0

Could you check my work and give feedback?

asked 2020-04-28 10:15:00 -0500

GruberLevente gravatar image

updated 2020-04-29 14:25:20 -0500

aze gravatar image
edit retag flag offensive close merge delete

1 answer

Sort by » oldest newest most voted
0

answered 2020-04-29 14:25:10 -0500

aze gravatar image

I think it's pretty good, you can improve on these a little:

  • You don't need to put everything into a div, this whole webpage actually pretty much can be done with just semantic elements and a few classes
  • For example with the lists, you can put the class on the ul then you don't need the outer containing div and the div inside (containing the li-s) is also unnecessary
  • Don't use style attributes on HTML, use CSS rules in the CSS part instead (and that inline-block display is also not needed at all, because you want to have the ul as a block, which is the default for them)
  • Try to use better names for your CSS classes than paragraph1 based on what it'll do, like smaller or small-and-bold

But the CSS part is nice, maybe you can try to merge a couple of rulesets using a bit more classes.

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2020-04-28 10:15:00 -0500

Seen: 77 times

Last updated: Apr 29